Disable iOS 12 cellular connectivity monitor by default #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've started seeing some crashes when using the `CTServiceRadioAccessTechnologyDidChange` notification within `ClientNetworkMonitor ` in production on iOS 12. This is an issue that's been reported in this radar: https://openradar.appspot.com/46873673 To provide a workaround for this problem, I'm adding the option to opt out of the new iOS 12 API and to instead use the stable pre-iOS 12 API. I'm planning to release a new version of SwiftGRPC with this fix after it's merged.
Updated to 0.8.1 and re-generated the Carthage project. This release is being made to fix a crash with the connectivity monitor.
MrMage
approved these changes
Mar 28, 2019
|
@rebello95 feel free to merge and cut a new release at your convenience. |
|
Thanks @MrMage. Going to merge-commit (instead of squashing) since these 2 changes are pretty distinct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've started seeing some crashes when using the
CTServiceRadioAccessTechnologyDidChangenotification withinClientNetworkMonitorin production on iOS 12. This is an issue that's been reported in this radar: https://openradar.appspot.com/46873673To provide a workaround for this problem, I'm adding the option to opt out of the new iOS 12 API and to instead use the stable pre-iOS 12 API.
I'm planning to release a new version of SwiftGRPC with this fix after it's merged, which is what the second commit of this PR reflects.